Magic door website, try breaking it. Feedback is welcome

[funvill]

Can you try and break this website?
http://door.abluestar.com/door.php

The source code can be found here

I am going to release this to the public next week for the magic door workshop

Make your own magic door workshop - July 19th, 2015 - Vancouver Hack Space

This website was paid for by this grant.

NEIGHBOURHOOD SMALL GRANTS 2015 - Fairy doors

Continuing the discussion from Do YOU want to apply for the small neighbourhood grants?: I have submitted the following project to the NEIGHBOURHOOD SMALL GRANTS. Its has been already submitted but if you have any suggestions for the next one I would love to hear about them. NEIGHBOURHOOD SMALL GRANTS 2015 - Fairy doors.pdf (115.7 KB) What is the name of your project? Please use a title that you can remember. Fairy portals Describe your project. Give as much detail as possible. (up to 330…

Its 4am so I expect that there will be some bugs. Suggestions and feedback is welcome!

[lukecyca]

Cool! Everything works for me. I didn’t add a new door but I clicked through all the parts of the site and didn’t notice any major problems. I also checked for responsiveness across a variety of screen shapes and sizes.

Minor fixes & Suggestions:

• On the about page, “They can lean one to” has a typo, but I would use a more active voice to match the preceding sentence. For example: “They lead us to”.
• The page <title>s are all the same, so after browsing the site for a while you can’t tell heads from tails in your history menu or back button. Consider using Magic Doors — <name of door>, etc.
• Shut off as many doo-dads on the Disqus interface as you can. They put so much crap on there by default.
• Here’s a version of your VHS logo that I cleaned up with better spacing and alignment. It’s the same dimensions as yours so you can just pop it in if you want.

[funvill]

Thank you @lukecyca for your feedback.

@lukecyca

The page <title>s are all the same

Fixed,

@lukecyca

On the about page, “They can lean one to” has a typo,

Yep, all the text and word thingies need to be updated by a person that speakers words well on paper.

@lukecyca

Shut off as many doo-dads on the Disqus interface as you can. They put so much crap on there by default.

There are not that many options in Disqus that I could find to change the interface and reduce the noise. Maybe I am looking in the wrong spot.

@lukecyca

Here’s a version of your VHS logo

Thank you, I will use your version of the logo.

@lukecyca

I didn’t add a new door

Don’t worry about submitting garbage data, the database will be cleared and updated with good data before the public sees it.

[Janet]

Looks good funvill. This is a great project.

[funvill]

Things that @wander found that need to be fixed. Mentioned on Slack

• Nice to have a home button that brings you back to the Vancouver area in case you mess the map up.
• There’s no upper bound on the number of characters in the description.
• No bounds on the slug url
  http://door.abluestar.com/door.php?act=view&slug=qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqq
• There’s no validation in the long and lat fields, you can type in characters/garbage.
• You can overwrite another entry simply by using the same name.
• Any spam control? Once a bot finds this is totally open, you will get crushed by spam junk.
• You need a curse word filter on this, seriously
• Have you warned people not to put personal information in the entries, that it’s a public db?
• Where’s your privacy policy? How do you protect people’s privacy?
• So you have a comments section that you can add pictures to? Do you hold new account postings for moderation?

[wander]

The description field has no limit. I put 40K characters in it.

[funvill]

@funvill

You need a curse word filter on this, seriously

Done. used this script GitHub - snipe/banbuilder: Composer package for censoring profanity in web applications, forums, etc.

@funvill

There’s no upper bound on the number of characters in the description.

Done, 20k of text.

@funvill

No bounds on the slug url

Done max 40 chars

@funvill

There’s no validation in the long and lat fields, you can type in characters/garbage.

Done, must be float.

[Shane]

It’s possible to add a door with no name. Name field size is checked, then it is stripped of any tags, so if the name is “

”, you get no name. Doesn’t horribly break anything.

[seanhagen]

This is a pretty minor thing, but damn dude, get your indentation straight

[seanhagen]

Some other stuff:

• you don’t need the trailing ‘?>’ if the file is pure PHP
• the page that you get when there’s an error is pretty plain. Could you not just re-render the submit page, with everything filled in, highlight the offending inputs, and have a div with a list of errors encountered?

[Rob_MacKenzie]

Notes on your slides:
slide3 = extra bullet
slide5 - colour spelled like an american
slide5 - word Acrylic cut off by image
slide5 - no period on 2nd bullet point
slide 6 - no period 2nd bullet
slide 6 - capitalization on “magical beings”?
slide 7 - do you actually need to cut out the design from the paper? I usually just glue it onto the ply
slide 10 - bad colour again
slide 10 - 3rd bullet cut off text
slide 11 - no period, first bullet
slide 11 - bottom text, inconsistent capitalization
skimmed through slides that are not quite done.
slide 17 - missing quotes on “add door” page wording
slide 19 - Low res VHS logo

[funvill]

@Rob_MacKenzie

Notes on your slides:

Thank you @Rob_MacKenzie I have fixed up all the changes you have suggested.

[funvill]

@Shane

It’s possible to add a door with no name.

Fixed, thanks @Shane

@seanhagen

This is a pretty minor thing, but damn dude, get your indentation straight

Fixed, Migrating from a text editor that uses tabs to one that is using spaces.